Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: change dark highlight for a11y #985

Merged
merged 3 commits into from Oct 6, 2022
Merged

Conversation

12rambau
Copy link
Collaborator

@12rambau 12rambau commented Oct 6, 2022

Fix #649

I spent some time on different forums and issues about color blindness (I am a geographer so it's also important to me when I'm producing maps) It seems that native is not the best choice effectively. Note that none of the existing Pygment highlighters are fully compatible with any vision deficiency.

ref:

Thus I installed the colorblindly extension for chrome and started playing with Pygments. It seems to me that the molokai is giving us the best results for Protanopia (read-blind) and Deuteranopia (green-blind) which are the most comons form of color blindness.

Here are demo in both Python an JSON:

normal green-b red-b
pyton python_n python_g python_r
json json_n json_g json_r

Let me know what you think

@12rambau 12rambau changed the title FIX: use dracula highlight for accessibility FIX: change dark highlight for a11y Oct 6, 2022
@12rambau 12rambau marked this pull request as ready for review October 6, 2022 14:51
Copy link
Collaborator

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, especially if it improves a11y - also dracula is a cooler name

@12rambau
Copy link
Collaborator Author

12rambau commented Oct 6, 2022

also dracula is a cooler name

Note that the final choice is unfortunately less cool, it's "monokai"

@12rambau 12rambau merged commit 9724d4b into pydata:main Oct 6, 2022
@12rambau 12rambau deleted the color-blind branch October 6, 2022 17:17
@choldgraf
Copy link
Collaborator

Not Dracula? Nooo revert revert 😅

@jarrodmillman jarrodmillman added this to the 0.12 milestone Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dark mode syntax highlighting isn't as color-blind friendly as the light mode
3 participants