Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove primary sidebar if empty #980

Merged
merged 2 commits into from Oct 5, 2022
Merged

fix: remove primary sidebar if empty #980

merged 2 commits into from Oct 5, 2022

Conversation

12rambau
Copy link
Collaborator

@12rambau 12rambau commented Oct 5, 2022

Fix #976

I think the jinja test was a bit too lazy. here I test the length of the links list. if 0 I don't display it

@12rambau 12rambau marked this pull request as ready for review October 5, 2022 08:19
@12rambau 12rambau marked this pull request as draft October 5, 2022 08:22
@12rambau 12rambau marked this pull request as ready for review October 5, 2022 08:32
choldgraf
choldgraf approved these changes Oct 5, 2022
View reviewed changes
Copy link
Collaborator

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me 👍

@12rambau 12rambau merged commit 6489f3b into pydata:main Oct 5, 2022
@12rambau 12rambau deleted the sidebar branch October 5, 2022 08:55
@jarrodmillman jarrodmillman added this to the 0.11 milestone Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@choldgraf choldgraf choldgraf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.11
Development

Successfully merging this pull request may close these issues.

sidebar issue w/ 0.11.0rc2
3 participants
@12rambau @choldgraf @jarrodmillman