Remove deprecated option for google analytics #975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarrodmillman
force-pushed
the
remove-google-analytics
branch
from
cec6109
to
baf1bc0
Compare
choldgraf
approved these changes
Oct 4, 2022
jarrodmillman
force-pushed
the
remove-google-analytics
branch
5 times, most recently
from
3941003
to
cb0e469
Compare
jarrodmillman
force-pushed
the
remove-google-analytics
branch
from
cb0e469
to
a49017c
Compare
|
@choldgraf This is ready to merge. The test failure is due to the test coverage decreasing b/c this PR removes several lines that used to be covered. There is no new untested code. See https://app.codecov.io/gh/pydata/pydata-sphinx-theme/pull/975 |
drammock
approved these changes
Oct 7, 2022
|
this should have been removed as well right ? |
oops. yes I think it should have. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the idea was to remove this in 0.12, but the comments are unclear. It was deprecated in 0.10, so I am assuming it should be removed after 0.11. But we can remove it now, if that is what folks prefer.