MAINT: update icons to fit Fontawesome 6 #963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So far so good, I played around in the pages and all the expected icons seem to be there, let me know if you are satisfied with the changes |
choldgraf
approved these changes
Sep 29, 2022
| @@ -75,6 +75,10 @@ function macroTemplate({ compilation }) { | |||
| href="{{ pathto('_static/vendor/fontawesome/${ | |||
| vendorVersions.fontAwesome | |||
| }/webfonts/fa-brands-400.woff2', 1) }}"> | |||
| <link rel="preload" as="font" type="font/woff2" crossorigin | |||
There was a problem hiding this comment.
How were we able to use fa regular before if we weren't loading it with webpack? Shouldn't we also have to remove something?
There was a problem hiding this comment.
that's an excellent question, the only regular we were using was the moon icon of the theme switcher. the problem with fontawesome is that it's everywhere on the web so maybe we all cache it somewhere in our browser
There was a problem hiding this comment.
that seems like the most likely explanation.
jarrodmillman
approved these changes
Sep 29, 2022
drammock
approved these changes
Sep 29, 2022
| @@ -75,6 +75,10 @@ function macroTemplate({ compilation }) { | |||
| href="{{ pathto('_static/vendor/fontawesome/${ | |||
| vendorVersions.fontAwesome | |||
| }/webfonts/fa-brands-400.woff2', 1) }}"> | |||
| <link rel="preload" as="font" type="font/woff2" crossorigin | |||
There was a problem hiding this comment.
that seems like the most likely explanation.
timhoffm
added a commit
to timhoffm/mpl-sphinx-theme
that referenced
this pull request
Nov 1, 2022
They are controlled by pydata-sphinx-theme.css. However, pydata-sphinx-theme changed the classes in v0.11.0 pydata/pydata-sphinx-theme#963. We need to update this as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #881
fab,fasandfarbyfa-solid,fa-regularandfa-brandsBonus: