Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Don't filter images that support the dark theme #942

Merged
merged 1 commit into from Sep 23, 2022
Merged

FIX: Don't filter images that support the dark theme #942

merged 1 commit into from Sep 23, 2022

Conversation

QuLogic
Copy link
Contributor

@QuLogic QuLogic commented Sep 22, 2022

Also document this filtering.

@QuLogic QuLogic mentioned this pull request Sep 23, 2022
Merged
@jarrodmillman jarrodmillman added this to the 0.11 milestone Sep 23, 2022
choldgraf
choldgraf approved these changes Sep 23, 2022
View reviewed changes
Copy link
Collaborator

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thanks for this improvement :-)

@choldgraf choldgraf changed the title Don't filter images that support the dark theme FIX: Don't filter images that support the dark theme Sep 23, 2022
@choldgraf choldgraf merged commit 2e09895 into pydata:main Sep 23, 2022
@QuLogic QuLogic deleted the no-dark-filter branch September 23, 2022 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarrodmillman jarrodmillman jarrodmillman approved these changes

@drammock drammock drammock approved these changes

@choldgraf choldgraf choldgraf approved these changes

@12rambau 12rambau Awaiting requested review from 12rambau

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.11
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@QuLogic @jarrodmillman @drammock @choldgraf