Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update Javascript dependencies #940

Merged
merged 2 commits into from Sep 21, 2022
Merged

update Javascript dependencies #940

merged 2 commits into from Sep 21, 2022

Conversation

drammock
Copy link
Collaborator

@drammock drammock commented Sep 21, 2022 •
edited

hopefully fixes what is blocking #882 and #934

@drammock drammock changed the title add postcss and postcss-loader to devDependencies update Javascript dependencies Sep 21, 2022
@drammock
Copy link
Collaborator Author

after this is merged it ought to be possible to comment @dependabot rebase on the linked PRs and (hopefully) have the builds succeed and the tests pass.

choldgraf
choldgraf approved these changes Sep 21, 2022
View reviewed changes
Copy link
Collaborator

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are happy so IMO we should just merge

@drammock drammock merged commit c481e96 into pydata:main Sep 21, 2022
@drammock drammock deleted the fix-webpack branch September 21, 2022 20:54
@jarrodmillman jarrodmillman added this to the 0.11 milestone Sep 22, 2022
@gabalafou gabalafou mentioned this pull request Mar 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@choldgraf choldgraf choldgraf approved these changes

@jarrodmillman jarrodmillman Awaiting requested review from jarrodmillman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.11
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@drammock @choldgraf @jarrodmillman