Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use hasdoc() for logo link #921

Merged
merged 1 commit into from Sep 15, 2022
Merged

use hasdoc() for logo link #921

merged 1 commit into from Sep 15, 2022

Conversation

drammock
Copy link
Collaborator

@drammock drammock commented Sep 8, 2022

closes #912

@datapythonista can you test with this branch? Locally I tested:

...but I don't have an easy way to test your setup (sphinx root is not / but rather /docs/, and you want logo to link to /).

Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, my setup is actually 3. By default the logo link would be to the root page (first if condition, e.g. ./index.html meaning /docs/index.html in my case), and what I need is just /, so all good with this.

Thanks a lot for the PR!

@jarrodmillman jarrodmillman added this to the 0.11 milestone Sep 8, 2022
@12rambau 12rambau merged commit 9765f72 into pydata:main Sep 15, 2022
@drammock drammock deleted the fix-logo-link branch September 15, 2022 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in logo link
4 participants