add css helper for images optimized for both dark and light theme #914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
choldgraf
reviewed
Sep 7, 2022
choldgraf
approved these changes
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #879
When switching from dark to light theme, image management can become complex. In the current implementation of pydata-sphinx-theme the images that have 0 specifications are added a white background when displayed in dark theme. On the other hand the user can specify a CSS helper class and duplicate its asset to make them look nice in both theme (
.only-dark,.only-light).As discussed in #879, the most common situation is to have images non optimised for dark background but in some cases, the images can work on both. In this PR I'm adding the
.dark-lightclass to setup these image and prevent the addition of the white background.