Fix plausible loading

[StefanUlbrich]

Fixes #905

However, tags are given to the add_js_file in the form of keyword arguments. The data-domain has a minus in it which disqualifies it as a python identifier, yet the fix works. I would have expected that python complains so I don't know if this is an acceptable solution. Comments?

[choldgraf]

This looks great to me! Thanks for the fix. I believe that the **kwargs pattern is a nice way to allow for - in Python arguments so it seems fine

[choldgraf]

oops I spoke too soon! can you please get the tests passing? :-)

[StefanUlbrich]

oops I spoke too soon! can you please get the tests passing? :-)

Well, OK. I adjusted the unit tests accordingly ;) .. They run locally and pre-commit inclusive

Having no-valid identifiers as keys in **kwargs does not seem that abnormal

[StefanUlbrich]

I accidentally added package.lock. Is this a problem?

[choldgraf]

Yes please don't modify package-lock.json unless it is relevant to this PR. I tried deleting it in the files but it looks like we just need to revert it to whatever is on main.

It looks good to me assuming that tests are happy + package lock is reverted.

[StefanUlbrich]

Yes please don't modify package-lock.json unless it is relevant to this PR. I tried deleting it in the files but it looks like we just need to revert it to whatever is on main.

It looks good to me assuming that tests are happy + package lock is reverted.

I think that the tests were happy (I cannot trigger them) and I somehow managed to get the file reverted (that took much longer than it should have). I rebased on main too along the process. @choldgraf , please let me know if there are any more issues

[StefanUlbrich]

Gentle reminder :-)

[choldgraf]

Looks good to me - thanks!