FIX: Fix equation scrolling behavior #872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
choldgraf
force-pushed
the
flex-equation
branch
from
8884fd9
to
0ed8761
Compare
This was referenced Aug 13, 2022
No preference, that was a one-liner that just took a couple minutes |
jarrodmillman
approved these changes
Aug 13, 2022
|
rendering looks good. https://pydata-sphinx-theme--872.org.readthedocs.build/en/872/user_guide/theme-elements.html#mathematics +1 for merge when CIs come back green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes a few CSS fixes to our equation scrolling behavior. Here's the summary:
mth-containerlevel, instead of thediv.mathlevel. This means that the equation label will always show up and only the equation will scroll.overflow: hiddenbehavior in general, and also closes Some inline equations have vertical scrollbars #858 (it also supercedes FIX: Hide vert scrollbars on inline math #871 but happy to merge that one first and incorporate here if @drammock prefers)