ENH: Improve sidebar secondary config and logic #849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm going to merge this in since it was undocumented before, and I think this is clearly a nicer structure. We should get an RC out so folks can use this! I hope that's OK |
choldgraf
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick config change that I wanted to get in before the release so we don't have to deprecate the config structure in the future. It uses periods (
.) to naturally "nest" page-level metadata so they behave more like ourhtml_theme_optionsconfiguration. This is inspired by how TOML does key nesting.AKA we go from:
theme_html_remove_secondary_sidebar:html_theme.sidebar_secondary.remove:I think this also fixes the bug that @tupui noted where an empty sidebar would still show up.