Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add light background to inline code #838

Merged
merged 1 commit into from Jul 25, 2022

Conversation

choldgraf
Copy link
Collaborator

This adds a lightweight background to our inline code to follow a pattern that is very common in other documentation platforms, and hopefluly makes inline code standout better.

Two quick points:

  • It doesn't change the code color at all, do people think we should change the color to be the same as our text?
  • It tries to add a light border that isn't intrusive, @drammock is it OK to you?

Here's an example in light/dark:

ShareX_lI80D2naEK

closes #837

@drammock
Copy link
Collaborator

Yes, border is acceptably subtle :). Thanks! Re: color, my vote is that it's better to have inline code a different color from both normal text and from links

Copy link
Collaborator

@12rambau 12rambau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as mentioned in the related issue, I like the pinky inline code of this theme.

LGTM

@choldgraf
Copy link
Collaborator Author

OK cool - since we've got two approvals and there's general preference for leaving the color as-is, let's do that and people can change the color on their own if they wish.

@choldgraf choldgraf merged commit 689ff93 into pydata:main Jul 25, 2022
@choldgraf choldgraf deleted the enh-inline-background branch July 25, 2022 08:12
@jarrodmillman jarrodmillman added this to the 0.10 milestone Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refine our inline code style
4 participants