New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCS: Update front page, contributing doc, and gallery code #825
Conversation
this looks really nice! I'll try to make time for a full review soon, but 2 things I noticed just browsing the rendered pages:
|
@drammock done in latest commit! |
Friendly ping for a review or approval on this one - I'd like to get these dangling PRs cleaned up so that we can release soon! Alternatively: does anybody object to me merging this once we clean up the merge conflicts? |
I won't be able to look again until Tuesday. Ideally one of the other devs has time to look; otherwise I don't object to a merge without full review. I did read through most of it and you already fixed what I spotted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's start from the start, I really like the new look of the front page and the general design that you added (gallery, contributors etc).
From the implementation point of view nothing to complain about (I saw that you changed the json file for a yaml in the gallery but that's cosmetic to me)
Unfortunately my level of English doesn't allow me to proofread the content...
I'd say you can merge and people will create patches if they see something
OK I'll get the merge conflicts fixed and will then merge this in so that we can iterate more easily on the other PRs! |
04f5fce
to
4c72f0a
Compare
There were quite a few merge conflicts that came up when I merged I'll give it a couple of hours in case anybody wants to hold off, and will give this another quick pass before merging and focusing efforts on #834 since that's the more complex one |
This makes a few revisions of our contributing documentation as well as our front page, with the goal of being a little bit more "visual" and less text-heavy, and breaking content into more natural sections.
It looks like I've touched a bunch of files but that is mostly because of the renames and removing some files. I tried to break it up into natural commits, and also describe a few major changes below:
contribute/
tocommunity/
and break that up into a few more specific sub-sections.demo/
toexamples/
to mimic the title we use on the website (for each of these, I thought it wouldn't be a problem if the links break since those probably rarely get linked-to, but let me know if you disagree).Footnotes
↩
↩