-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: External logo image, nbsphinx spacing, admonition title #797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
choldgraf
commented
Jul 11, 2022
choldgraf
changed the title
Fix nbsphinx spacing and logo link
Fix External logo image source and fix nbsphinx spacing
Jul 11, 2022
choldgraf
changed the title
Fix External logo image source and fix nbsphinx spacing
ENH: External logo image source and fix nbsphinx spacing
Jul 11, 2022
12rambau
reviewed
Jul 11, 2022
src/pydata_sphinx_theme/theme/pydata_sphinx_theme/components/navbar-logo.html
Outdated
Show resolved
Hide resolved
choldgraf
changed the title
ENH: External logo image source and fix nbsphinx spacing
ENH: External logo image source, fix nbsphinx spacing, fix admonition title
Jul 12, 2022
12rambau
approved these changes
Jul 12, 2022
choldgraf
commented
Jul 12, 2022
src/pydata_sphinx_theme/assets/styles/extensions/_execution.scss
Outdated
Show resolved
Hide resolved
choldgraf
commented
Jul 12, 2022
Just cleaned up two little bugs I found, will merge this one if the non-pre-release tests are happy |
choldgraf
changed the title
ENH: External logo image source, fix nbsphinx spacing, fix admonition title
ENH: External logo image, nbsphinx spacing, admonition title
Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does two quick fixes for issues we have in 0.10: