Style code blocks after GitHub #784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drammock
reviewed
Jul 5, 2022
| @@ -4,4 +4,7 @@ | |||
| */ | |||
| // This will impact the top offset for many sections | |||
| --pst-header-height: 3rem; | |||
|
|
|||
| // Border radius | |||
| --pst-border-radius: 0.2rem; | |||
There was a problem hiding this comment.
is this new variable getting used anywhere? I don't see it in the diff...
There was a problem hiding this comment.
whoops - you're right, will remove
choldgraf
commented
Jul 5, 2022
drammock
approved these changes
Jul 5, 2022
12rambau
approved these changes
Jul 5, 2022
choldgraf
commented
Jul 7, 2022
|
OK it seems like folks are generally happy with this one, so I'll merge it in and we can iterate in subsequent PRs, thanks for the feedback! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes a few small modifications to our code blocks to take some inspiration from the GitHub code block styling. Here are the major changes:
1rem)Below are a few GIFs to show the old / new behavior:
Code blocks
Notebooks
closes #783
Feedback?
I know this is a slight visual change to the code blocks, so if anybody disagrees with the change let me know. My rationale is that we are not design experts, and debating whether padding should be
10pxor16pxis probably not a good use of our time, and so we should just pick a design system that is well-used and thoughtful regarding code, and follow that (thus, GitHub styles). Personally, I also think the extra spacing is a little bit cleaner and nicer for reading.