Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Overflow content on configuration #772

Merged
merged 1 commit into from
Jul 1, 2022
Merged

FIX: Overflow content on configuration #772

merged 1 commit into from
Jul 1, 2022

Conversation

choldgraf
Copy link
Collaborator

@choldgraf choldgraf commented Jun 29, 2022 •
edited

This adds overflow-x: auto to prevent wide content from pushing out the secondary sidebar

Old / broken: https://pydata-sphinx-theme.readthedocs.io/en/latest/user_guide/configuring.html
New / fixed: https://pydata-sphinx-theme--772.org.readthedocs.build/en/772/user_guide/configuring.html

closes #771
closes #768

@choldgraf
Copy link
Collaborator Author

cc @mwaskom - maybe this would fix some of those issues in the seaborn docs?

@12rambau
Copy link
Collaborator

Is there a page in our demo documentation that was showing the same issue as in seaborn one ? From my computer everything looks the same.

@choldgraf
Copy link
Collaborator Author

yep:

Old / broken: https://pydata-sphinx-theme.readthedocs.io/en/latest/user_guide/configuring.html
New / fixed: https://pydata-sphinx-theme--772.org.readthedocs.build/en/772/user_guide/configuring.html

12rambau
12rambau approved these changes Jun 29, 2022
View reviewed changes
Copy link
Collaborator

@12rambau 12rambau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

then that's a big yes. nobody wants a sidebar to remain at the bottom

@mwaskom
Copy link

mwaskom commented Jun 29, 2022

Nice! It looks like this fixes my problem.

@choldgraf
Copy link
Collaborator Author

wooo amazing, OK I will mark this as closing your issue too then

@choldgraf choldgraf merged commit 2f729ca into pydata:main Jul 1, 2022
@choldgraf choldgraf deleted the fix-overflow branch July 1, 2022 09:15
@jarrodmillman jarrodmillman added this to the 0.10 milestone Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@12rambau 12rambau 12rambau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.10
4 participants
@choldgraf @12rambau @mwaskom @jarrodmillman