-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dropdown menu to header navigation #754
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's a good idea and I like the implementation.
See my comment about the gallery change
Since this one is already improving the spacing of the header, I added closes #763 |
Co-authored-by: Rambaud Pierrick <12rambau@users.noreply.github.com>
thanks for the reviews all! |
@choldgraf there are a few issues with the styling:
Another thought, perhaps these "dropdowns" would use the Although, the only pain is that it is not as easy to "connect" them to a URL anchor: https://lazacode.org/2029/html-select-and-go-to-url-with-onchange-event-attribute |
Thanks for that feedback - I opened up a new issue to track it here: #769 |
This adds the ability to place some of the header navigation links in a Dropdown menu rather than being displayed immediately. By default the first 5 header links are displayed, and the remaining ones are placed in a dropdown menu. The number that are displayed can also be controlled with a new configuration variable. This should help save space for sites that have many header links or long titles (I believe @mwaskom had a use-case like this).
I've also added a few extra external links so we can demo this on our docs, and set our number of displayed links to 4 instead of 5 (matching the links we already have)
Here's a quick example:
To do
closes #571 closes closes #763