Only install Chromium with Playwright #750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm an idiot and turned the gallery into a comment in that last PR :-) will fix here @12rambau |
|
Assuming that tests are happy, I'll merge this one in because our gallery is currently broken :-D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only installs Chromium with our
playwright installcommand and documents it as well. This should cut down on unnecessary download/install time. By default, playwright installs a few different browsers but we only need one in order to take the snapshots.It also fixes a bug where we turned the gallery into an rST comment, and adds
richto our gallery gen script so it's a bit easier to read and understand what's happening.