ENH: Use JupyterLab cell background color for surface variables #747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
choldgraf
changed the title
12rambau
approved these changes
Jun 22, 2022
|
Merging this one in since we had an approve and I just needed to refactor the PR for the latest structural changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minor change to our default "surface" variable. Since we use this variable for
preand code cells, since we've discussed harmonizing themes with Jupyter/JupyterLab in #745, and since this is a relatively small change in general (and brings our CSS more in-line with pygments defaults as well), this seemed like a reasonable choice!