-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Improve quotes display CSS #743
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good in general - two quick thoughts:
- The text doesn't seem to be selectable, I wonder if the
&after
is floating above it in the blockquotes? - Could we add some padding just above and below the text? I think we could just re-use the same top/bottom padding that github uses
I removed to margins of the
There is a margin-bottom associated with
There is nothing on top of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one quick comment in there, if that resolves it then I think we should merge
OK so setting I think there are 3 ways we could get around this:
I think it's going to confuse people that they can't obviously select text inside of quotes, so IMO it's something we should try to fix (I know it's technically possible via double clicking and such but that feels like a weird UX to me) |
We initially set back the admonition background when we were playing with the colors to increase the contrast in the dark background so I would say we really want to keep it. I will go with the simple z-index hack for this specific use case. it's harmless and works just fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! Let's give it a go! Thanks @12rambau
Fix #454
The quotes were using a legacy color.
Used the now-classic trick of admonition to display quotes in light grey using a left border (grey as well. It looks more like what we see on other platforms like GitHub and is working with any quote directive including
epigraph
,highlight
andpull-quote
.