Add NBSphinx support for dark theme #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that the broken link test is now fixed on |
|
I double-checked this locally and it seems to work well w/ nbsphinx:
I also added some instructions for how others could test nbsphinx locally. I think we are good to merge this unless anybody objects! |
choldgraf
commented
Jun 23, 2022
|
OK I'm gonna merge this one in because it's fixing a display bug, and (at least locally) I think I've fixed it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a few cleanups and improvements:
I don't believe that we can demo both nbsphinx and myst-nb in the same docs (they both grab the
ipynbextension so can only use one). But I believe this does it and we'll need to rely on community reports if functionality breaks.@blaylockbk want to test that this works OK for your use-case?
closes #739