FIX: Make hover color work on version switcher #731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Works! Screenshot from the PR build (you can't see the mouse in the screenshot, but it's over the 0.8.0 item):
Dark mode:
|
choldgraf
approved these changes
Jun 15, 2022
choldgraf
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds :hover highlighting to elements in the version switcher. I think this used to work before the various scss refactorings / color variable standardizations (which are great BTW!)... I think so because when building our site based on current
mainof the theme I see this in the inspector:but
git grep "248, 249, 250"fails as doesgit grep -i f8f9faso I'm assuming that rule's been cleaned up/removed already?