Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Version switcher dark mode support #719

Merged
merged 4 commits into from
Jun 11, 2022
Merged

Conversation

12rambau
Copy link
Collaborator

@12rambau 12rambau commented Jun 11, 2022

Fix #711

Edit the theme switcher so that it fits the dark theme.

normal items: on-background color.
stable item (in our doc only): transparent success background + success text color
active item: transparent primary background + primary text color

@12rambau 12rambau marked this pull request as ready for review June 11, 2022 13:46
@jarrodmillman
Copy link
Collaborator

This works for me!

@jarrodmillman jarrodmillman added this to the 0.9.1 milestone Jun 11, 2022
Copy link
Collaborator

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, nice improvement!

@choldgraf choldgraf changed the title customize theme switcher ENH: Version switcher dark mode support Jun 11, 2022
@choldgraf choldgraf merged commit 1845990 into pydata:main Jun 11, 2022
@12rambau 12rambau deleted the switcher branch June 11, 2022 20:23
@jarrodmillman jarrodmillman modified the milestones: 0.9.1, 0.10 Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dropdown menu should have dark theme support
3 participants