Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

force table to fit in the article width #717

Merged
merged 4 commits into from
Jun 11, 2022
Merged

Conversation

12rambau
Copy link
Collaborator

@12rambau 12rambau commented Jun 11, 2022

Fix #716. The table now use there block display so they respect the max-width parameter (100%). As there will be a scroll bar at the bottom of the overflow table I also added the scrollbar methods to table elements.

Fix #205 Add a Giant content table to illustrate word wrapping.

https://pydata-sphinx-theme--717.org.readthedocs.build/en/717/demo/kitchen-sink/lists-and-tables.html#giant-tables

@12rambau 12rambau marked this pull request as ready for review June 11, 2022 12:11
@12rambau
Copy link
Collaborator Author

Happy to receive feedback but more importantly, I don't understand why the Audit is crashing, any help from maintainers will be much apreciated

@jorisvandenbossche
Copy link
Member

Looks good!

At some point in the past we also fixed this (#174), although I see it already has not been working anymore for several releases. I assume because the old css rule was specific to some output in sphinx that changed (the section class, while now it a section element).
Anyway, the old CSS is still present in _article.scss, so might be good to clean that up.

Copy link
Collaborator

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

docs/demo/kitchen-sink/lists-and-tables.rst Outdated Show resolved Hide resolved
Co-authored-by: Chris Holdgraf <choldgraf@gmail.com>
@12rambau
Copy link
Collaborator Author

so might be good to clean that up.

Done

@jarrodmillman
Copy link
Collaborator

why the Audit is crashing

I've noticed that it fails somewhat regularly. When I notice it, I've just been re-running failed jobs from the actions interface. I've been meaning to look into making it more reliable, but haven't looked into it yet. I will try to at least create an issue the next time it happens (unless someone beats me to it).

@jarrodmillman
Copy link
Collaborator

See #720.

@jarrodmillman jarrodmillman merged commit de915c6 into pydata:main Jun 11, 2022
@12rambau 12rambau deleted the table branch June 11, 2022 15:35
@jarrodmillman jarrodmillman added this to the 0.9.1 milestone Jun 11, 2022
@jarrodmillman jarrodmillman modified the milestones: 0.9.1, 0.10 Jul 1, 2022
@gabalafou gabalafou mentioned this pull request May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

giant table overlaps with secondary sidebar Text wrap in tables
4 participants