New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use different logos for light and dark theme #691
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! A few quick ideas/comments from me but this is looking good!
src/pydata_sphinx_theme/theme/pydata_sphinx_theme/components/navbar-logo.html
Outdated
Show resolved
Hide resolved
src/pydata_sphinx_theme/theme/pydata_sphinx_theme/components/navbar-logo.html
Outdated
Show resolved
Hide resolved
src/pydata_sphinx_theme/theme/pydata_sphinx_theme/components/navbar-logo.html
Outdated
Show resolved
Hide resolved
src/pydata_sphinx_theme/theme/pydata_sphinx_theme/components/navbar-logo.html
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks pretty good to me! A few quick suggestions on docs wording
@@ -38,3 +38,6 @@ page_sidebar_items = page-toc.html, edit-this-page.html | |||
switcher = | |||
pygment_light_style = tango | |||
pygment_dark_style = native | |||
light_logo = | |||
dark_logo = | |||
html_title = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this isn't necessary because html_title
is built into Sphinx, I believe
Co-authored-by: Chris Holdgraf <choldgraf@gmail.com>
Co-authored-by: Chris Holdgraf <choldgraf@gmail.com>
Co-authored-by: Chris Holdgraf <choldgraf@gmail.com>
Co-authored-by: Chris Holdgraf <choldgraf@gmail.com>
Co-authored-by: Chris Holdgraf <choldgraf@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made a few small docs tweaks! This looks good to me! I am going to merge and try this out in #698 !
I had not removed the html_title from conf 馃槃. I will clean it somewhere else |
I removed it just before merge but reintroduced a version of it back into the branding update PR 馃檪 |
I refactored navbar-logo.html to support 3 different logo structures (2 logos, 1 logo, no logo). I made the following modifications:
find the link
As the same link will be used whatever the logo, I decided to set a variable at the begining of the file
2 logos
The user set the logos in the defined static folder and set the relative path in the options:
I then create 2 independant logos, one using
only-dark
the otheronly-light
.This option only works if both the logo are set
demo ?
As long as the theme documentation has not yet a logo (please have look in #373) I cannot really demo it here. you can either trust me (not recomended) or test it on one of your doc and let me know 馃槃
Fixes #674 fixes #545