move all the CSS variable to a single folder #686
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
description
The variables were split between
assets
andstatic
making it difficult to track them.In this PR I decided to follow the structure used in Furo: https://github.com/pradyunsg/furo/tree/main/src/furo/assets/styles/variables with a single
variables
folder and split the variables in small sementic files.There are then called in index.scss
side modifications
question
I have little understanding of the webpack builder so I left the
theme.css
file in static, it's just reduced to 1 single line. I thinkwebpack.conf.js
could be updated to directly import this unique file. If someone knows, please let me know in the review.related to
Fix #676