Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move all the CSS variable to a single folder #686

Merged
merged 5 commits into from Jun 2, 2022

Conversation

12rambau
Copy link
Collaborator

description

The variables were split between assets and static making it difficult to track them.
In this PR I decided to follow the structure used in Furo: https://github.com/pradyunsg/furo/tree/main/src/furo/assets/styles/variables with a single variables folder and split the variables in small sementic files.

There are then called in index.scss

side modifications

  • I edited the documentation to make it point to the correct files
  • I changed sidebar variables to respect ng-sphinx structure

question

I have little understanding of the webpack builder so I left the theme.css file in static, it's just reduced to 1 single line. I think webpack.conf.js could be updated to directly import this unique file. If someone knows, please let me know in the review.

related to

Fix #676

@12rambau 12rambau marked this pull request as ready for review May 31, 2022 22:13
Copy link
Collaborator

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a reasonable change to me! I think that we might need to keep the theme.css just to have that import statement in there, I'm not sure how else to pass a "regular CSS import statement" into an SCSS file without it being compiled.

@12rambau 12rambau merged commit 5e6d489 into pydata:main Jun 2, 2022
@12rambau 12rambau deleted the variables branch June 2, 2022 08:11
@jarrodmillman jarrodmillman added this to the 0.9 milestone Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Put our CSS variables in assets instead of static
3 participants