Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test against prereleases #683

Merged
merged 1 commit into from Jun 1, 2022
Merged

Conversation

jarrodmillman
Copy link
Collaborator

@jarrodmillman jarrodmillman commented May 28, 2022

We should probably use

python -m pip install  --pre -e .

instead of

python -m pip install --upgrade --pre -e .

I.e., without the --upgrade. But I wanted to test with upgrades to see if there were some potential upper pins that I should investigate. Thoughts?

@jarrodmillman jarrodmillman marked this pull request as draft May 28, 2022 14:43
@jarrodmillman jarrodmillman marked this pull request as ready for review May 28, 2022 14:55
@jarrodmillman jarrodmillman marked this pull request as draft May 28, 2022 14:56
@jarrodmillman jarrodmillman force-pushed the prerelease branch 2 times, most recently from 24ad09c to 4050b7c Compare May 28, 2022 15:00
@choldgraf
Copy link
Collaborator

This definitely makes sense to me - thanks for tracking down the weird pinning behavior.

@jarrodmillman
Copy link
Collaborator Author

The more I think about it, the more I think maybe we should keep the --upgrade option. If it ends up causing too much noise, we can revisit.

@choldgraf
Copy link
Collaborator

I'm not sure I understand the implications of --upgrade vs not, so I defer to your and others' expertise!

@jarrodmillman jarrodmillman marked this pull request as ready for review May 28, 2022 21:49
Copy link
Contributor

@larsoner larsoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I've used --upgrade --pre in other repos for the past couple of years to catch problems ahead of time

@choldgraf choldgraf merged commit 2e8f415 into pydata:main Jun 1, 2022
@choldgraf
Copy link
Collaborator

Let's do it!

larsoner added a commit to larsoner/pydata-sphinx-theme that referenced this pull request Jun 1, 2022
* upstream/main:
  Test against prereleases (pydata#683)
@jarrodmillman jarrodmillman added this to the 0.9 milestone Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants