Rearrange sections to use basic-ng names #662
Conversation
|
cc @damianavila and @12rambau since you have been helping a lot so far :-) it would be great if we could get this merged relatively quickly because it will become out of date soon |
There was a problem hiding this comment.
I know very few things about basic-ng but the documentation build nicely and I didn't spot any buggy section. In general, the tidying work is super good it's way easier to navigate in the files and elements.
I don't know if it was already the case before but the use of the BEM synthax is much appreciated!
I think this new classes will be very helpfull for #641
|
|
||
| {% block docs_navbar %} | ||
| <nav class="navbar navbar-light navbar-expand-lg bg-light fixed-top bd-navbar" id="navbar-main"> | ||
| {%- include "docs-navbar.html" %} | ||
| <nav class="bd-header-primary navbar navbar-light navbar-expand-lg bg-light fixed-top bd-navbar" id="navbar-main"> |
There was a problem hiding this comment.
Why is this class bd-header-primary and not bd-header as the section name and the image you shared in the PR ?
There was a problem hiding this comment.
good catch! the latest push renames this to just header!
|
Ping on this one - any other changes people would like to see here? |
|
ok cool let's merge this one in, then, and iterate from there! |
This rearranges our template structure in order to align with the basic-ng theme structure. It roughly follows this structure (from the basic-ng example build)
It should not change any user-facing things. Here are the main changes:
layout.htmlnow broken up into several parts insections/bd-header-primaryandbd-header-primary__container)componentsfolder instead of_templates(so it's clearer what kinds of things go there)I think there is still more we could do (particularly, cleaning up and organizing the
componentsfolder because it is a bit messy now). But I think we could do that in future PRs.last part of #610
Follow-ups that we could try after this PR (for future ref):
components/so that it is broken into section-specific areas (e.g.nav/icon-links.htmlinstead ofnav-icon-links.html).bd-sidebar-primaryand deprecatebd-sidebar).