Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Clean up navbar spacing on mobile #644

Merged
merged 2 commits into from May 11, 2022

Conversation

choldgraf
Copy link
Collaborator

@choldgraf choldgraf commented Apr 26, 2022

This is a small improvement to the spacing of icons on mobile. It adds a bit of vertical spacing and makes the icon links stack horizontally.

See this before/after GIF:

chrome_gEJS4Znaea

@damianavila
Copy link
Collaborator

I like the change... it is an improvement because it is eating less vertical space.
Maybe there is a way to have all the switchers and icons aligned in one horizontal line?

@choldgraf
Copy link
Collaborator Author

OK - the latest push applies the same logic to all navbar-end items, so anything in the right-most navbar area should now be stacked horizontally.

@choldgraf
Copy link
Collaborator Author

Will merge this one as I think that I addressed your suggestion

@choldgraf choldgraf merged commit 5f9e38f into pydata:master May 11, 2022
@choldgraf choldgraf deleted the navbar-mobile branch May 11, 2022 13:29
@damianavila
Copy link
Collaborator

Thanks!

@jarrodmillman jarrodmillman added this to the 0.9 milestone May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants