Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Avoid secondary navbar overlap #642

Merged
merged 2 commits into from Apr 26, 2022
Merged

Conversation

12rambau
Copy link
Collaborator

@12rambau 12rambau commented Apr 23, 2022

Fix #638

The jinja variable was out of scope when used. As it's not a big deal, I'm doing the "if" statement in both blocks using the ternary operator.

seems to work in the pre-build.

@12rambau 12rambau changed the title use namespace for jinja variable avoid secondary navbar overlap Apr 23, 2022
@12rambau 12rambau marked this pull request as ready for review April 23, 2022 12:37
Copy link
Collaborator

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a cleaner and more understandable fix, thanks :-)

@choldgraf choldgraf changed the title avoid secondary navbar overlap FIX: Avoid secondary navbar overlap Apr 26, 2022
@choldgraf choldgraf merged commit 0df2cc3 into pydata:master Apr 26, 2022
@12rambau 12rambau deleted the patch-1 branch April 26, 2022 11:58
@jarrodmillman jarrodmillman added this to the 0.9 milestone Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

the secondary sidebar overlap with the primary sidebar
3 participants