Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Adapt target viewcode to tango highlighting style #635

Merged
merged 2 commits into from Apr 22, 2022

Conversation

12rambau
Copy link
Collaborator

@12rambau 12rambau commented Apr 22, 2022

  • add the viewcode extention in the demo site
  • use variables for the coloring

Fix #634

@12rambau 12rambau marked this pull request as ready for review April 22, 2022 11:07
@choldgraf
Copy link
Collaborator

is there a place in our docs where we can see this in action? It is hard to understand the effects of this without that :-)

Also - it would be useful if we created a section for Sphinx extensions in our colors module, and put all extension-specific CSS rules underneath that section. So similar to how we have sections like:

  /*****************************************************************************
  * layout
  */

We could also have a section like:

  /*****************************************************************************
  * Extensions
  */

@12rambau
Copy link
Collaborator Author

is there a place in our docs where we can see this in action? It is hard to understand the effects of this without that :-)

That's the main purpose of the second commit, result is here: https://pydata-sphinx-theme--635.org.readthedocs.build/en/635/_modules/pandas/core/frame.html#DataFrame.drop

@12rambau
Copy link
Collaborator Author

Also - it would be useful if we created a section for Sphinx extensions in our colors module, and put all extension-specific CSS rules underneath that section. So similar to how we have sections like

Can we keep this one as a comment and see when I'll deal with #623 ?

Copy link
Collaborator

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me - this looks good to go IMO, I tried it on dark mode and it looks nice :-)

@choldgraf choldgraf changed the title adapt target viewcode to tango highlighting style ENH: Adapt target viewcode to tango highlighting style Apr 22, 2022
@choldgraf choldgraf merged commit 281e103 into pydata:master Apr 22, 2022
@12rambau 12rambau deleted the target branch May 31, 2022 20:53
@jarrodmillman jarrodmillman added this to the 0.9 milestone Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

targeted viewcode doesn't work at all with tango (dark theme).
3 participants