Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Minor updates and tweaks to Dark theme CSS #631

Merged
merged 3 commits into from Apr 18, 2022

Conversation

12rambau
Copy link
Collaborator

@12rambau 12rambau commented Apr 16, 2022

I solved som small issues that I saw in the dark theme by using it:

  • change the color of the search field input (it was displayed in grey so completely invisible)
  • use variable for sidebar border color
  • change target coloring (the used light blue was not working with the new H1 colors and the spans were still in yellow)

PS:
Fix #630

Copy link
Collaborator

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me in general - though why did you decide to revert the search bar design updates? I believe those were added in #578

@12rambau
Copy link
Collaborator Author

12rambau commented Apr 17, 2022

Because I saw it in the "stable" version of the doc. I thought that was a mistake I made in #540.
@choldgraf lucky me that was the last commit. I've reverted it so now I'm not changing the search bar design any more

Copy link
Collaborator

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM - thanks for the improvements and clean-up after the first PR!

@choldgraf choldgraf changed the title small update to issues in the dark-theme ENH: Minor updates and tweaks to Dark theme CSS Apr 18, 2022
@choldgraf choldgraf merged commit a716ab7 into pydata:master Apr 18, 2022
@12rambau 12rambau deleted the sidebar branch May 31, 2022 20:53
@jarrodmillman jarrodmillman added this to the 0.9 milestone Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

the left sidebar border is not visible in dark theme
3 participants