Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a url type for navbar icons #616

Merged
merged 9 commits into from Apr 8, 2022

Conversation

maximlt
Copy link
Contributor

@maximlt maximlt commented Apr 2, 2022

Partially addresses #603

Copy link
Collaborator

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems pretty good to me! One quick typo I found but it looks good in general. Just to be clear, the CSS and behavior is no different from the "local" use-case right? If that's the case it's probably not a big deal that we don't demo this in our theme documentation .

also I think you'll need to update one of the regression tests just FYI!

tests/test_build/navbar_icon_links.html Outdated Show resolved Hide resolved
@maximlt
Copy link
Contributor Author

maximlt commented Apr 3, 2022

Just to be clear, the CSS and behavior is no different from the "local" use-case right? If that's the case it's probably not a big deal that we don't demo this in our theme documentation .

You're right, no change in CSS and behavior. So I've merged the Local Image Icons and URL Icons (the section I added originally) into an Image Icons section. I think it's still worth documenting it.

@choldgraf
Copy link
Collaborator

I think this one looks good to go in my opinion. The failing tests were because the pre-commit hook had the wrong black dependency specified. I've updated that on master and if you merge master into this branch, I bet the tests will pass. Wanna give that a shot?

@maximlt
Copy link
Contributor Author

maximlt commented Apr 8, 2022

Sure let's see if now they pass :) I've merged master.

@choldgraf
Copy link
Collaborator

I've made a slight modification to the docs to fix a failing test and to help separate out the url and local examples a bit more. I think this is ready to go!

@choldgraf choldgraf changed the title Add a url type of icons Add a url type for navbar icons Apr 8, 2022
@choldgraf choldgraf merged commit ba74dd8 into pydata:master Apr 8, 2022
@choldgraf
Copy link
Collaborator

many thanks for the improvement @maximlt !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants