Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STYLE: Update default anchor link #593

Merged
merged 1 commit into from Feb 23, 2022

Conversation

choldgraf
Copy link
Collaborator

@choldgraf choldgraf commented Feb 21, 2022

This demonstrates what our docs would look like with a # as the default anchor link, rather than the paragraph icon. I also updated some of the CSS for the anchors itself, to be a little bit more visually pleasing, and following the Bootstrap docs style/behavior

OLD:

chrome_IgTf2LIQmT

NEW:

chrome_cnQVvFcqj6

closes #592

Copy link
Collaborator

@damianavila damianavila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I like the # version of the link!

@choldgraf
Copy link
Collaborator Author

Will hold off for 24hrs or so to merge in case others have thoughts!

@choldgraf choldgraf merged commit 2f0f7fa into pydata:master Feb 23, 2022
@choldgraf choldgraf deleted the style-anchor-link branch February 23, 2022 21:24
@jorisvandenbossche
Copy link
Member

Nice improvement!

@choldgraf choldgraf mentioned this pull request Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use a # icon for our permalinks
3 participants