Show the right sidebar on wider screens if the left is hidden

[jorisvandenbossche]

Experiment for #568

[choldgraf]

I don't see any obvious difference in the right sidebar when the left sidebar is hidden.

Hidden sidebar: https://pydata-sphinx-theme--570.org.readthedocs.build/en/570/demo/no-sidebar.html
Not hidden: https://pydata-sphinx-theme--570.org.readthedocs.build/en/570/demo/index.html

@jorisvandenbossche are you still interested in working on this PR?

[damianavila]

@choldgraf you need to compare the left hidden sidebar example in this PR:

• https://pydata-sphinx-theme--570.org.readthedocs.build/en/570/demo/no-sidebar.html

against the behavior in stable:

• https://pydata-sphinx-theme.readthedocs.io/en/stable/demo/no-sidebar.html.

If you narrow the horizontal space, you will see a different behavior.

[choldgraf]

Ah I see - I've re-titled the PR so that it is more reflective of the current change. I was looking for a change in width of some kind, but I see it is only the change in the screen width at which the right sidebar is hidden.

I'm fine with this change, though I'm worried that the implementation is going to be confusing for people - all of these conditional bootstrap class checks are a bit hard to wrap your head around without the context of what they're doing. So I guess I'm +0, but we definitely should add comments to the changes here so that a person with no context would understand what they're doing

[damianavila]

So I guess I'm +0, but we definitely should add comments to the changes here so that a person with no context would understand what they're doing

I agree with your thoughts here, @choldgraf

[damianavila]

but we definitely should add comments to the changes here so that a person with no context would understand what they're doing

Any feeling about the depth of the comments you want to add here @choldgraf?

[damianavila]

Any feeling about the depth of the comments you want to add here @choldgraf?

Pinging @choldgraf again on this one 😉.

[choldgraf]

I added a few quick commits to add more comments, and to use one if statement that sets variables and re-uses them, rather than two. I think that this makes it easier to read and understand. I'm +1 on merging this one and seeing how people like it.

[choldgraf]

Merging this in since we don't have any suggestions otherwise! We can tweak this over time