MAINT: Add OSX and Windows build to tests #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
pre-commit.ci autofix edit: this was a test to see if I could get it to manually trigger, but it didn't work as expected so I'm just removing the bot again, disregard this :-) |
|
@pradyunsg figured out the windows bug in pradyunsg/sphinx-theme-builder#9 so let's see if this now works as expected. If the tests pass then I'll merge this in, and maybe @drammock can give it a shot once more from windows. |
|
OK tests are happy, so I'm going to consider #523 resolved! But if somebody tries this on windows and it doesn't work, we can re-open and spot-check |
choldgraf
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick attempt to see if we can add a Windows and an OSX build with minimal extra configuration.
closes #523