FIX: Compatibility with sphinx 4.3 (visit_table) #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you ! Ran into this; reported it at executablebooks/sphinx-book-theme#427. Thanks for fixing it. |
tomwhite
added a commit
to tomwhite/sgkit
that referenced
this pull request
Nov 11, 2021
|
Not even one day of down time, awesome @jorisvandenbossche ! |
tk0miya
reviewed
Dec 13, 2021
| if LooseVersion(sphinx.__version__) < LooseVersion("4.3"): | ||
| self._table_row_index = 0 | ||
| else: | ||
| self._table_row_indices.append(0) |
There was a problem hiding this comment.
The second and subsequent elements of the list are used for the nested tables. So you should not append the value if you'd like to make a new nested table.
The last element always points to the current table. So it's better to modify its value like following:
self._table_row_indices[-1] = 0
matthewevans
pushed a commit
to aptech/pydata-sphinx-theme
that referenced
this pull request
Dec 16, 2021
This was referenced Jan 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.