Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid adding margin to docutils container (from bootstrap container) #474

Merged

Conversation

jorisvandenbossche
Copy link
Member

I know that in #323 we more or less decided against this, but I again ran into an issue where the added margin to a docutils container doesn't help (in this case a C++ API docs from doxygen / breathe).

I could also add this CSS to our custom CSS in the upstream package, but IMO this seems relatively safe to do here, since it specifically selects only those divs where there is also a docutils class (so it should normally never be a div that was created manually to work with bootstrap containers).

We can't really check this in our demo docs, since we don't have this case (but I checked this works for the arrow docs).

@jorisvandenbossche
Copy link
Member Author

So we actually do have one case in our demo docs that runs into this: the jupyter-sphinx code cells and output blocks: https://pydata-sphinx-theme--474.org.readthedocs.build/en/474/demo/demo.html#html

Here, this change doesn't really improve things though .. (it looks strange without any margin). But you could also say that this is up to jupyter-sphinx, as it's their CSS that only gives the pre block 4px of padding.

Copy link
Collaborator

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me - for the future, these are the kinds of issues that we should think about in deciding whether we want to continue depending on Bootstrap, or instead use something like @pradyunsg's sphinx-basic-ng template to give us the structure we need.

@jorisvandenbossche jorisvandenbossche merged commit a020b1f into pydata:master Sep 30, 2021
@jorisvandenbossche jorisvandenbossche deleted the docutils-container branch September 30, 2021 13:08
matthewevans pushed a commit to aptech/pydata-sphinx-theme that referenced this pull request Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants