Improve styling of the Previous / Next buttons #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We could also more completely copy what you did for sphinx-book-theme? (I personally like the layout and styling as you have it there (and in furo ..)) |
|
Sounds good, i will give it a shot |
|
@jorisvandenbossche done in the latest push! I also factored out the prevnext stuff into its own little template so that it was easier to reason with
|
3 tasks
|
Thanks! I tweaked the css a bit to have it only underline the title (underlying the icon gives a bit strange effect I think). And made the space between the two lines a bit smaller |
jorisvandenbossche
force-pushed
the
prev_next
branch
from
baaea67
to
92948e1
Compare
|
I love it, thanks! +1 from me |
jorisvandenbossche
changed the title
matthewevans
pushed a commit
to aptech/pydata-sphinx-theme
that referenced
this pull request
Dec 16, 2021
Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the previous / next buttons align with the arrows when they span multiple lines. It also makes them an explicit HTML element rather than using a CSS rule to put in the text. This is probably easiest shown by example.
current behavior:
this PR:
closes #469