Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: remove double quotes in github actions #1062

Merged
merged 1 commit into from Nov 14, 2022
Merged

Conversation

12rambau
Copy link
Collaborator

The latest prerelease run failed because of an error in the yaml file: https://github.com/pydata/pydata-sphinx-theme/actions/runs/3458681079

searching on the web, I found out that even though double quotes are legit in a yaml file, they are not currently supported by github actions

specifically:

You must use single quotes. Escape literal single quotes with a single quote.

myString: ${{ 'Mona the Octocat' }}

In order to avoid confusion for the next contributors I decided to remove all the unnecessary double quotes.

@12rambau 12rambau marked this pull request as ready for review November 14, 2022 08:29
@choldgraf choldgraf merged commit 3ac01cf into pydata:main Nov 14, 2022
@12rambau 12rambau deleted the actions branch November 14, 2022 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants