Disable CloudFlare Rocket loader on dark mode script #1045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this PR. As we already discussed it's a very specific fix but completely harmless for the rest of the site so I'm +1 for merging. I think it also solved #943. |
12rambau
approved these changes
Nov 1, 2022
|
the doc is not build because scipy documentation site is not accecible right now (scipy/docs.scipy.org#69) I'll relaunch the build this is solved |
QuLogic
added a commit
to matplotlib/matplotlib.github.com
that referenced
this pull request
Nov 3, 2022
choldgraf
reviewed
Nov 3, 2022
If it's enabled, then the initialization of the dark mode does not occur early enough, and the page will flash from light-to-dark if that was the saved theme. See the CloudFlare documentation for details: https://support.cloudflare.com/hc/en-us/articles/200168056-Understanding-Rocket-Loader
QuLogic
force-pushed
the
fix-cf-rocket
branch
from
ace06cd
to
b2a06dc
Compare
choldgraf
approved these changes
Nov 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If it's enabled, then the initialization of the dark mode does not occur early enough, and the page will flash from light-to-dark if that was the saved theme.
See the CloudFlare documentation for details:
https://support.cloudflare.com/hc/en-us/articles/200168056-Understanding-Rocket-Loader
Fixes #959
I've temporarily added this on https://matplotlib.org so you can see that this is working. It is not added on any other page, which you can use for comparison.