-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prerelease CI: Update name, schedule and Python version #1044
Conversation
A bit of maintenance on the prerelease GitHub Actions workflow: - Rename the workflow to better reflect it's purpose - Run twice a week (instead of once) on Monday and Thursday early in the morning. - Set fail-fast to false, so that all jobs finish and don't get cancelled if one fails. - Run the warnings check test on Python 3.10
I will let others better suited to evaluate the pre-release modifications but regarding the |
Ah so it tracks know warnings, sounds like a smart approach! Could you enable the workflow to see how it runs? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Co-authored-by: Daniel McCloy <dan@mccloy.info>
Thanks for reviewing! I see two green review checks, anything else needed to merge this? |
I just authorized the CI run and we have some failures; @EwoutH can you take a look? |
This is quite a strange error, could you retrigger the CI to see if it’s CI/network related?
|
I refreshed the CI and everything run smoothly, I assume the error was network related. As we already have 2 approvals I'm going to merge this one |
A bit of maintenance on the prerelease GitHub Actions workflow:
fail-fast
tofalse
, so that all jobs finish and don't get cancelled if one fails.I was also wondering, it looks like a
warnings.txt
file is generated on each run. Should we upload or save that somewhere, or is that already the case?