Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prerelease CI: Update name, schedule and Python version #1044

Merged
merged 2 commits into from Nov 4, 2022

Conversation

EwoutH
Copy link
Contributor

@EwoutH EwoutH commented Oct 30, 2022

A bit of maintenance on the prerelease GitHub Actions workflow:

  • Rename the workflow to better reflect it's purpose
  • Run twice a week (instead of once) on Monday and Thursday early in the morning.
  • Set fail-fast to false, so that all jobs finish and don't get cancelled if one fails.
  • Run the warnings check test on Python 3.10

I was also wondering, it looks like a warnings.txt file is generated on each run. Should we upload or save that somewhere, or is that already the case?

A bit of maintenance on the prerelease GitHub Actions workflow:
 - Rename the workflow to better reflect it's purpose
 - Run twice a week (instead of once) on Monday and Thursday early in the morning.
 - Set fail-fast to false, so that all jobs finish and don't get cancelled if one fails.
- Run the warnings check test on Python 3.10
@12rambau
Copy link
Collaborator

I will let others better suited to evaluate the pre-release modifications but regarding the warning.txt, yes it's built each time and we test it against a saved version (https://github.com/pydata/pydata-sphinx-theme/blob/main/tests/warning_list.txt). Many surprises came from our dependencies in the past I would advocate keeping it that way

@EwoutH
Copy link
Contributor Author

EwoutH commented Oct 30, 2022

Ah so it tracks know warnings, sounds like a smart approach!

Could you enable the workflow to see how it runs?

Copy link
Collaborator

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

.github/workflows/prerelease.yml Outdated Show resolved Hide resolved
Co-authored-by: Daniel McCloy <dan@mccloy.info>
@EwoutH
Copy link
Contributor Author

EwoutH commented Nov 4, 2022

Thanks for reviewing! I see two green review checks, anything else needed to merge this?

@drammock
Copy link
Collaborator

drammock commented Nov 4, 2022

I just authorized the CI run and we have some failures; @EwoutH can you take a look?

@EwoutH
Copy link
Contributor Author

EwoutH commented Nov 4, 2022

This is quite a strange error, could you retrigger the CI to see if it’s CI/network related?

ValueError: not enough values to unpack (expected 1, got 0)
[657](https://github.com/pydata/pydata-sphinx-theme/actions/runs/3388675217/jobs/5648412373#step:4:658)
      error: nodeenv-creation-failed
[658](https://github.com/pydata/pydata-sphinx-theme/actions/runs/3388675217/jobs/5648412373#step:4:659)
      
[659](https://github.com/pydata/pydata-sphinx-theme/actions/runs/3388675217/jobs/5648412373#step:4:660)
      × Failed to create a `nodeenv`
[660](https://github.com/pydata/pydata-sphinx-theme/actions/runs/3388675217/jobs/5648412373#step:4:661)
      ╰─> See above for failure output from the underlying tooling.
[661](https://github.com/pydata/pydata-sphinx-theme/actions/runs/3388675217/jobs/5648412373#step:4:662)
      
[662](https://github.com/pydata/pydata-sphinx-theme/actions/runs/3388675217/jobs/5648412373#step:4:663)
      hint: A `urllib.error.HTTPError` indicates that the issue is related to the
[663](https://github.com/pydata/pydata-sphinx-theme/actions/runs/3388675217/jobs/5648412373#step:4:664)
            network or the availability of NodeJS release files. It may mean the node
[664](https://github.com/pydata/pydata-sphinx-theme/actions/runs/3388675217/jobs/5648412373#step:4:665)
            version that this tool is trying to fetch is no longer available, for
[665](https://github.com/pydata/pydata-sphinx-theme/actions/runs/3388675217/jobs/5648412373#step:4:666)
            example if there is no compatible NodeJS binary for the operating system.
[666](https://github.com/pydata/pydata-sphinx-theme/actions/runs/3388675217/jobs/5648412373#step:4:667)
      link: https://sphinx-theme-builder.rtfd.io/errors/#nodeenv-creation-failed
[667](https://github.com/pydata/pydata-sphinx-theme/actions/runs/3388675217/jobs/5648412373#step:4:668)
      [end of output]

@12rambau
Copy link
Collaborator

12rambau commented Nov 4, 2022

I refreshed the CI and everything run smoothly, I assume the error was network related. As we already have 2 approvals I'm going to merge this one

@12rambau 12rambau merged commit 0a4894f into pydata:main Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants