Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: style table generated by myst-NB #1041

Merged
merged 3 commits into from Nov 3, 2022
Merged

FIX: style table generated by myst-NB #1041

merged 3 commits into from Nov 3, 2022

Conversation

12rambau
Copy link
Collaborator

@12rambau 12rambau commented Oct 27, 2022 •
edited

@12rambau 12rambau marked this pull request as ready for review October 27, 2022 07:00
choldgraf
choldgraf reviewed Oct 27, 2022
View reviewed changes
Copy link
Collaborator

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me - though we have a bunch of notebooks-specific CSS in the execution page as well:

https://github.com/12rambau/pydata-sphinx-theme/blob/notebook/src/pydata_sphinx_theme/assets/styles/extensions/_execution.scss

Should we merge and rename execution to notebooks?

@12rambau
Copy link
Collaborator Author

I would merge nbsphinx and myst-nb together in _notebooks and I'would keep jupyter-sphinx (and later jupyterlite) in _execution

choldgraf
choldgraf approved these changes Nov 3, 2022
View reviewed changes
Copy link
Collaborator

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - I think the new notebooks file makes sense 👍

@choldgraf choldgraf merged commit 50873e7 into pydata:main Nov 3, 2022
@12rambau 12rambau deleted the notebook branch November 4, 2022 21:38
@gabalafou gabalafou mentioned this pull request Apr 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@choldgraf choldgraf choldgraf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wide notebook outputs should have a max-width and scroll
2 participants
@12rambau @choldgraf