Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: create a navbar_persistent section #1022

Merged
merged 4 commits into from Oct 18, 2022
Merged

Conversation

12rambau
Copy link
Collaborator

@12rambau 12rambau commented Oct 18, 2022

Fix #1006
May superceed #1020

Instead of adding complex CSS rules to make sure the search button cannot be displayed with the search bar this PR simply adds an extra area in the navbar: navbar_persistentthat will do exactly what the current search button is doing now.

I also adapted the documentation accordingly

to make the search-button disappear:

html_theme_options: {
    #...
    "navbar_persistent": [],
    #...
}

@12rambau 12rambau marked this pull request as ready for review October 18, 2022 08:09
Copy link
Collaborator

@drammock drammock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this LGTM, much better than the approach in #1020.

docs/user_guide/layout.rst Outdated Show resolved Hide resolved
Co-authored-by: Daniel McCloy <dan@mccloy.info>
@12rambau 12rambau merged commit b9dc483 into pydata:main Oct 18, 2022
@12rambau 12rambau deleted the search-bis branch October 18, 2022 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search button configuration
2 participants