Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Add skip to main content button for a11y #1019

Merged
merged 3 commits into from Oct 20, 2022
Merged

ENH: Add skip to main content button for a11y #1019

merged 3 commits into from Oct 20, 2022

Conversation

12rambau
Copy link
Collaborator

Fix #966

respecting all the instructions from the video shared in the issue + some of our own css tricks (colors + z-index)

@12rambau 12rambau marked this pull request as ready for review October 17, 2022 09:38
choldgraf
choldgraf approved these changes Oct 19, 2022
View reviewed changes
Copy link
Collaborator

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great - thanks! Just a few comments

src/pydata_sphinx_theme/theme/pydata_sphinx_theme/layout.html Outdated Show resolved Hide resolved
src/pydata_sphinx_theme/theme/pydata_sphinx_theme/layout.html Show resolved Hide resolved
src/pydata_sphinx_theme/assets/styles/sections/_skip-link.scss Outdated Show resolved Hide resolved
12rambau and others added 2 commits October 19, 2022 21:59
@12rambau @choldgraf
add ref
4a556b8 
Co-authored-by: Chris Holdgraf <choldgraf@gmail.com>
@12rambau @choldgraf
add ref
f53c4f3 
Co-authored-by: Chris Holdgraf <choldgraf@gmail.com>
choldgraf
choldgraf approved these changes Oct 20, 2022
View reviewed changes
Copy link
Collaborator

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me - will merge it in and we can iterate from there if there is more feedback

@choldgraf choldgraf changed the title ENH: add skip link ENH: Add skip to main content button for a11y Oct 20, 2022
@choldgraf choldgraf merged commit 2e1cfab into pydata:main Oct 20, 2022
@12rambau 12rambau deleted the a11y branch October 20, 2022 09:01
@oscargus
Copy link
Contributor

oscargus commented Dec 9, 2022

I have some issues with this on my Chromium 103 running under CentOS 7. The bar is always visible. Not sure if there is anything to do on your side though or if I just have to live with this (hiding all the Matplotlib menu items)?

Yes, they are old, but for certain scenarios one needs to run specific OS...

Is there a way to disable this is the settings? I understand that it is useful from an accessibility perspective, but I also guess that if the structure is reasonably simple anyway it may not be wanted/required.

@choldgraf
Copy link
Collaborator

@oscargus here's one way to do it:

@gabalafou gabalafou mentioned this pull request Sep 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@choldgraf choldgraf choldgraf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add an off-page button to skip to main content
3 participants
@12rambau @oscargus @choldgraf