FIX: link shortening for gitlab #1012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
choldgraf
reviewed
Oct 11, 2022
choldgraf
reviewed
Oct 11, 2022
There was a problem hiding this comment.
Looks great to me - so that we cover each of these edge-cases, could we:
-
In the docs, show off all of the different ways that you could display the links. E.g.:
- https://github.com/pydata/pydata-sphinx-theme/pull/1012 - https://github.com/pydata/pydata-sphinx-theme - https://github.com/pydata/ -
In the tests, do the same so that we're testing each of the edge-cases and would uncover bugs like these?
choldgraf
approved these changes
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the links in GitLab are using an extra "-" for issues in the url.
Fix #1011