Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: update switcher list #1009

Merged
merged 4 commits into from Oct 12, 2022
Merged

FIX: update switcher list #1009

merged 4 commits into from Oct 12, 2022

Conversation

12rambau
Copy link
Collaborator

#1008

wait for confirmation of the list in the issue

@12rambau 12rambau marked this pull request as ready for review October 11, 2022 07:28
Copy link
Collaborator

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for me - though my feeling is that we should only include, say, the latest versions in the last 3 minor series (so latest/, v0.10.1, v09.0, and v0.8.1). We want to strongly encourage people to keep up with the latest releases.

Copy link
Collaborator

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - maybe we should wait a day or two to make sure nobody else on the team wants to keep some other version in the list?

@drammock
Copy link
Collaborator

My feeling is that 5 versions is a good number to keep in the menu. Can you add to the "how to make a release" docs that when adding the new version to the .json that the oldest one should be removed?

One option I've heard suggested elsewhere is to have a link "older versions" that goes to an orphan HTML page that lists all the versions. I'm neutral as to whether to do that; I like the completeness but also feel it's rarely going to be useful.

@choldgraf
Copy link
Collaborator

+1 on last 5 versions from me (though I think we should stick to "the latest patch release within minor releases"

@drammock
Copy link
Collaborator

I think we should stick to "the latest patch release within minor releases"

yes, I was thinking that too (but didn't make it clear)

@12rambau
Copy link
Collaborator Author

I updated the list with the last 5 + dev branch

@12rambau 12rambau merged commit 6d3968a into pydata:main Oct 12, 2022
@12rambau 12rambau deleted the versions branch October 12, 2022 15:39
@jarrodmillman jarrodmillman added this to the 0.12 milestone Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants