Fixing HTML bugs

pydata · Jul 20, 2022 · 7880031 · 7880031
1 parent a91921c
commit 7880031
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/src/pydata_sphinx_theme/__init__.py b/src/pydata_sphinx_theme/__init__.py
@@ -249,10 +249,10 @@ def generate_nav_html(
                 links_dropdown_html = "\n".join(links_dropdown)
                 out += f"""
                 <div class="nav-item dropdown">
-                    <button class="btn dropdown-toggle nav-item" type="button" id="dropdownMenuButton" data-toggle="dropdown" aria-haspopup="true" aria-expanded="false">
+                    <button class="btn dropdown-toggle nav-item" type="button" data-toggle="dropdown" aria-haspopup="true" aria-expanded="false">
                         More
                     </button>
-                    <div class="dropdown-menu" aria-labelledby="dropdownMenuButton">
+                    <div class="dropdown-menu">
                         {links_dropdown_html}
                     </div>
                 </div>
@@ -358,7 +358,7 @@ def navbar_align_class():
         }
         if align not in align_options:
             raise ValueError(
-                "Theme optione navbar_align must be one of"
+                "Theme option navbar_align must be one of"
                 f"{align_options.keys()}, got: {align}"
             )
         return align_options[align]

diff --git a/src/pydata_sphinx_theme/theme/pydata_sphinx_theme/components/version-switcher.html b/src/pydata_sphinx_theme/theme/pydata_sphinx_theme/components/version-switcher.html
@@ -3,7 +3,7 @@
         {{ theme_switcher.get('version_match') }}  <!-- this text may get changed later by javascript -->
         <span class="caret"></span>
     </button>
-    <div class="version-switcher__menu dropdown-menu list-group-flush py-0" aria-labelledby="version-switcher__button">
+    <div class="version-switcher__menu dropdown-menu list-group-flush py-0">
     <!-- dropdown will be populated by javascript on page load -->
     </div>
 </div>

diff --git a/src/pydata_sphinx_theme/theme/pydata_sphinx_theme/sections/sidebar-primary.html b/src/pydata_sphinx_theme/theme/pydata_sphinx_theme/sections/sidebar-primary.html
@@ -3,7 +3,7 @@
 <div class="bd-sidebar-primary bd-sidebar{% if not sidebars %} hide-on-wide{% endif %}">
   {# Header items that will be displayed in the sidebar on mobile #}
   <div class="sidebar-header-items sidebar-primary__section">
-    <p class="sidebar-header-items__title" role="heading" aria-label="{{ _('Navigation') }}">
+    <p class="sidebar-header-items__title" role="heading" aria-level="1" aria-label="{{ _('Navigation') }}">
       {{ _("Navigation") }}
     </p>
     {# The header center items #}

diff --git a/tests/test_build/navbar_switcher.html b/tests/test_build/navbar_switcher.html
@@ -5,7 +5,7 @@
   <span class="caret">
   </span>
  </button>
- <div aria-labelledby="version-switcher__button" class="version-switcher__menu dropdown-menu list-group-flush py-0">
+ <div class="version-switcher__menu dropdown-menu list-group-flush py-0">
   <!-- dropdown will be populated by javascript on page load -->
  </div>
 </div>