Fixes #933
Open
Fixes #933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bashtage I'm not sure what these failed tests mean or how to proceed. If you can give any guidance on what needs to be fixed I can take care of it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes problems in:
FamaFrenchReader with encoding in one file
YahooDailyReader will now return a a DataFrame of nans when a single symbol has no data
closes Key Error (trying to fetch out of range data) #932
closes french library that contain operating profit not working #852
tests added / passed
passes
git diff upstream/master -u -- "*.py" | flake8 --diffpasses
black --check pandas_datareaderadded entry to docs/source/whatsnew/vLATEST.txt
Sorry, I'm kind of a github idiot so I'm sure I'm doing something wrong but these are two pretty quick fixes that don't appear to break anything else. I'm happy to try again if someone can give me guidance about what else needs to be done here.