Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/enable custom datareader #896

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

begoat
Copy link

@begoat begoat commented Aug 2, 2021

@bashtage
Copy link
Contributor

bashtage commented Aug 2, 2021

What does this bring that end users couldn't accomplish with subclassing?

@begoat
Copy link
Author

begoat commented Aug 2, 2021

What does this bring that end users couldn't accomplish with subclassing?

Hi @bashtage

I came across this problem. #895
I cannot figure out one way to request https://stooq.com/q/d/l/?s=USDJPY

@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2021

Codecov Report

Merging #896 (a1e7a8e) into main (b1247d1) will decrease coverage by 1.60%.
The diff coverage is 90.62%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #896      +/-   ##
==========================================
- Coverage   73.15%   71.54%   -1.61%     
==========================================
  Files          65       65              
  Lines        2932     2963      +31     
  Branches      315      316       +1     
==========================================
- Hits         2145     2120      -25     
- Misses        705      760      +55     
- Partials       82       83       +1     
Impacted Files Coverage Δ
pandas_datareader/__init__.py 40.90% <ø> (ø)
pandas_datareader/data.py 66.66% <78.57%> (+1.69%) ⬆️
pandas_datareader/tests/test_data.py 100.00% <100.00%> (ø)
pandas_datareader/tests/test_eurostat.py 40.47% <0.00%> (-59.53%) ⬇️
pandas_datareader/eurostat.py 61.29% <0.00%> (-25.81%) ⬇️
pandas_datareader/io/sdmx.py 80.00% <0.00%> (-11.43%) ⬇️
pandas_datareader/io/util.py 66.66% <0.00%> (-11.12%) ⬇️
pandas_datareader/tests/test_iex.py 94.44% <0.00%> (-5.56%) ⬇️
pandas_datareader/compat/__init__.py 86.84% <0.00%> (-2.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1247d1...a1e7a8e. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stooq.com cannot get data related to USDJPY
3 participants